-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add config file #207
Merged
Merged
fix: add config file #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: scepter914 <[email protected]>
Signed-off-by: scepter914 <[email protected]>
Signed-off-by: scepter914 <[email protected]>
kminoda
reviewed
Jan 31, 2024
kminoda
previously approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Confirmed that
- Autoware launches with this PR (and related PRs).
- Parameters are successfully modified when I modify the .param.yaml file.
See also: TIER IV INTERNAL LINK FOR REWORK PRs
Signed-off-by: scepter914 <[email protected]>
…p_launcher into fix/perception_parameter_config
kminoda
approved these changes
Feb 1, 2024
yuki-takagi-66
pushed a commit
that referenced
this pull request
Feb 21, 2024
* fix parameter files Signed-off-by: scepter914 <[email protected]> * fix parameter files Signed-off-by: scepter914 <[email protected]> * add a config file of simple_object_merger Signed-off-by: scepter914 <[email protected]> * ci(pre-commit): autofix * fix CMakeFile Signed-off-by: scepter914 <[email protected]> --------- Signed-off-by: scepter914 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
TomohitoAndo
pushed a commit
that referenced
this pull request
Jun 12, 2024
* fix parameter files Signed-off-by: scepter914 <[email protected]> * fix parameter files Signed-off-by: scepter914 <[email protected]> * add a config file of simple_object_merger Signed-off-by: scepter914 <[email protected]> * ci(pre-commit): autofix * fix CMakeFile Signed-off-by: scepter914 <[email protected]> --------- Signed-off-by: scepter914 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: t4-x2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add radar config files for aip_launch